Migrate VPN and rp service to Docker Compose #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhadapaithankar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10901-vpn-service
branch
from
41d8d97
to
a6ded87
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
SudoBrendan
previously approved these changes
Oct 9, 2024
slawande2
previously approved these changes
Oct 9, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please rebase pull request. |
…ry prefix before it is pushed to the ACR.
shubhadapaithankar
dismissed stale reviews from slawande2 and SudoBrendan
via
0249c98
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10901-vpn-service
branch
from
303370b
to
0249c98
Compare
slawande2
approved these changes
Oct 10, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
approved these changes
Oct 10, 2024
shubhadapaithankar
deleted the
shubhadapaithankar/ARO-10901-vpn-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes : ARO-9501
What this PR does / why we need it:
This PR migrates the
VPN,RP,andPortal servicesto Docker Compose, simplifying service management by containerizing them. Thedocker-compose.ymlnow orchestrates all three services. This migration makes the environment setup and service orchestration more efficient and maintainable, improving local development and CI/CD workflows.Key Updates:
Dockerfile.vpn, allowing for easier configuration of the VPN through Docker Compose.Dockerfile.ci-rpand is defined indocker-compose.yml, with the health checks in place to ensure proper operation.docker-compose.yml, with secrets mounted, environment variables passed, and the necessary portal command defined to run the service correctly.Other Important Highlights:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?